| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench tap tests & minor fixes |
| Date: | 2017-05-08 16:53:10 |
| Message-ID: | 20170508165310.vboap2fnfno7s3a3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO wrote:
>
> Here is a v3, with less files. I cannot say I find it better, but it still
> works.
>
> The "command_likes" function has been renamed "command_checks".
Do parts of this need to be backpatched? I notice that you're patching
pgbench.c, probably to fix some bug(s); is the idea that we would
backpatch all the new tests on whatever old branches need the bugfixes
too? If so, how far back do the fixes need to go?
ISTM TestLib::command_checks() needs a comment explaining what it does.
Its API seems pretty opaque.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-05-08 16:54:06 | Debian "postgresql-common" config check issue with pg10 |
| Previous Message | Andres Freund | 2017-05-08 16:42:52 | Re: [BUGS] Concurrent ALTER SEQUENCE RESTART Regression |