From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WITH clause in CREATE STATISTICS |
Date: | 2017-05-03 18:57:00 |
Message-ID: | 20170503185700.cwnkep6p3yjaeqot@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost wrote:
> > Here I add one, which seems to work for me.
Pushed it -- I also added another one which specifies options, to test
WITH handling in ruleutils.
> > Considering that Stephen missed a terminating semicolon for test with
> > create_order 96 (the last one prior to my commit) in commit
> > 31a8b77a9244, I propose that we change whatever is concatenating those
> > strings append a terminating semicolon. (Surely we don't care about two
> > tests stanzas writing a single SQL command by omitting the semicolon
> > terminator.)
>
> Whoops, sorry about that. Yes, we could pretty easily add that. The
> create SQL is built up at the bottom of 002_pg_dump.pl:
>
> $create_sql .= $tests{$test}->{create_sql};
Okay, I added it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-05-03 19:14:27 | PROVE_FLAGS |
Previous Message | Magnus Hagander | 2017-05-03 18:51:49 | Re: password_encryption, default and 'plain' support |