| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |
| Date: | 2017-05-03 03:05:20 |
| Message-ID: | 20170503030520.GR21223@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit,
* Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
> Attached updated patches.
Please find an updated version which corrects the issue with
binary-upgrade of partitioned tables having partitions in other schemas,
along with a few other minor improvements.
If you could take a look at it, I'd appreciate it. We already had a
test case in the pg_dump TAP tests for partitions existing in a schema
different from the partitioned table, but we weren't checking the
binary-upgrade case, so I've added a check to do that now. I'm sure
additional tests would be good to add and will take a look at doing that
tomorrow, but this hopefully closes at least the latest issue.
Assuming this looks good to you, I'll push it tomorrow, possibly with
other minor adjustments and perhaps a few more tests.
Thanks!
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| fix_pg_dump_with_partitioning_v1-master.patch | text/x-diff | 23.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2017-05-03 04:32:54 | Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode |
| Previous Message | Vaishnavi Prabakaran | 2017-05-03 02:13:08 | Re: check with serial |