Re: an outdated comment for hash_seq_init.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: robertmhaas(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: an outdated comment for hash_seq_init.
Date: 2017-04-26 08:31:28
Message-ID: 20170426.173128.180695546.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 25 Apr 2017 11:00:16 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in <CA+TgmobU=F1JtGZ+bL91D7sE2+cBybmJ+WMQdmTT0cyV2dvO0Q(at)mail(dot)gmail(dot)com>
> On Mon, Apr 24, 2017 at 3:55 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > While I looked into dynahash.c, I found that the following
> > sentense became outdated by 5dfc198. The commit removed the only
> > usage of hash_freeze().
> >
> >> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
> >> * worry about hash_seq_term cleanup, if the hashtable is first locked against
> >> * further insertions by calling hash_freeze. This is used by nodeAgg.c,
> >> * wherein it is inconvenient to track whether a scan is still open, and
> >> * there's no possibility of further insertions after readout has begun.
> >
> > The attached patch removes the sentence begins with "This is used
> > by..".
>
> Committed.

Thanks.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-04-26 08:32:19 Re: Foreign Join pushdowns not working properly for outer joins
Previous Message Kyotaro HORIGUCHI 2017-04-26 08:30:38 Re: statement_timeout is not working as expected with postgres_fdw