Re: Patch - Tcl 8.6 version support for PostgreSQL

From: Andres Freund <andres(at)anarazel(dot)de>
To: Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Cc: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch - Tcl 8.6 version support for PostgreSQL
Date: 2017-04-25 05:57:39
Message-ID: 20170425055739.5cciwasbngqjycvh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-04-22 23:28:49 +0530, Sandeep Thakkar wrote:
> diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
> index 304edf9..d3ef89f 100644
> --- a/src/tools/msvc/Mkvcbuild.pm
> +++ b/src/tools/msvc/Mkvcbuild.pm
> @@ -253,7 +253,12 @@ sub mkvcbuild
> $solution->AddProject('pltcl', 'dll', 'PLs', 'src\pl\tcl');
> $pltcl->AddIncludeDir($solution->{options}->{tcl} . '\include');
> $pltcl->AddReference($postgres);
> - if (-e $solution->{options}->{tcl} . '\lib\tcl85.lib')
> + if (-e $solution->{options}->{tcl} . '\lib\tcl86t.lib')
> + {
> + $pltcl->AddLibrary(
> + $solution->{options}->{tcl} . '\lib\tcl86t.lib');
> + }
> + elsif (-e $solution->{options}->{tcl} . '\lib\tcl85.lib')
> {
> $pltcl->AddLibrary(
> $solution->{options}->{tcl} . '\lib\tcl85.lib');

> diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
> index 30c1265..2667591 100644
> --- a/src/tools/msvc/Mkvcbuild.pm
> +++ b/src/tools/msvc/Mkvcbuild.pm
> @@ -208,7 +208,12 @@ sub mkvcbuild
> $solution->AddProject('pltcl', 'dll', 'PLs', 'src/pl/tcl');
> $pltcl->AddIncludeDir($solution->{options}->{tcl} . '/include');
> $pltcl->AddReference($postgres);
> - if (-e $solution->{options}->{tcl} . '/lib/tcl85.lib')
> + if (-e $solution->{options}->{tcl} . '/lib/tcl86t.lib')
> + {
> + $pltcl->AddLibrary(
> + $solution->{options}->{tcl} . '/lib/tcl86t.lib');
> + }
> + elsif (-e $solution->{options}->{tcl} . '/lib/tcl85.lib')
> {
> $pltcl->AddLibrary(
> $solution->{options}->{tcl} . '/lib/tcl85.lib');

Any chance of formulating these in a version agnostic way, instead of
copying the same stanza for every version? E.g. using a wildcard or
such...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-04-25 06:03:42 Re: Adding support for Default partition in partitioning
Previous Message Sandeep Thakkar 2017-04-25 05:54:40 Re: Patch - Tcl 8.6 version support for PostgreSQL