| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: walsender & parallelism |
| Date: | 2017-04-23 23:43:03 |
| Message-ID: | 20170423234303.ljzdpcog2szyxbsm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-04-21 04:20:26 +0200, Petr Jelinek wrote:
> Looks like SIGUSR1 being different is problem here - it's normally used
> to . I also noticed that we don't handle SIGINT (query cancel).
I think we really need to unify the paths between walsender and normal
backends to a much larger degree.
> BTW while looking at the code, I don't understand why we call
> latch_sigusr1_handler after calling SetLatch(MyLatch), shouldn't just
> the SetLatch be enough (they both end up calling sendSelfPipeByte()
> eventually)?
Historic raisins - there didn't use to be a SetLatch in
procsignal_sigusr1_handler. That changed when I whacked around catchup &
notify to be based on latches ([1] and following).
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-04-23 23:51:06 | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |
| Previous Message | Andres Freund | 2017-04-23 23:25:04 | Re: StandbyRecoverPreparedTransactions recovers subtrans links incorrectly |