| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: A note about debugging TAP failures |
| Date: | 2017-04-22 19:45:15 |
| Message-ID: | 20170422194515.zeuq5fu4kqx6k7y6@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-04-22 13:51:30 -0400, Tom Lane wrote:
> I think we need to fix TestLib and/or PostgresNode so that there's a way
> to make TAP tests not auto-clean their data directories at end of run,
> without having to resort to editing the script like this.
I think leaving the directory around in case of failures would be a
pretty bare minimum. It's sometimes also useful to keep the remains if
everything was apparently successfull, but it's far less important imo.
To me it sounds like we shouldn't use a randomly generated temporary
name, but rather a static mapping based on the test's path or such, to
create the relevant temp directory. Before a start a test could then
clean that up, that way the amount of remaining cruft would be bound by
the number of tests.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-04-22 20:09:11 | Re: tablesync patch broke the assumption that logical rep depends on? |
| Previous Message | Fabien COELHO | 2017-04-22 19:38:43 | Re: A note about debugging TAP failures |