| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | coelho(at)cri(dot)ensmp(dot)fr |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, rafia(dot)sabih(at)enterprisedb(dot)com, michael(dot)paquier(at)gmail(dot)com, Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, robertmhaas(at)gmail(dot)com, pavel(dot)stehule(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgbench - allow to store select results into variables |
| Date: | 2017-04-20 08:06:40 |
| Message-ID: | 20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Hello,
>
>> I think you'd better to change the following comments because there's
>> no psqlscan.l or psqlscanslash.l in pgbench source tree.
>>
>> + * underscore. Keep this in sync with the definition of
>> variable_char in
>> + * psqlscan.l and psqlscanslash.l.
>
> Here is a v3 with a more precise comment.
Looks good to me. I have marked the patch status as "Ready for
committer".
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paresh More | 2017-04-20 08:32:04 | Patch - Tcl 8.6 version support for PostgreSQL |
| Previous Message | Michael Paquier | 2017-04-20 07:35:17 | Re: DROP SUBSCRIPTION, query cancellations and slot handling |