| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | michael(dot)paquier(at)gmail(dot)com |
| Cc: | david(dot)rowley(at)2ndquadrant(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, david(at)pgmasters(dot)net, robertmhaas(at)gmail(dot)com, peter(dot)eisentraut(at)2ndquadrant(dot)com, bruce(at)momjian(dot)us, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Should pg_current_wal_location() become pg_current_wal_lsn() |
| Date: | 2017-04-19 08:30:24 |
| Message-ID: | 20170419.173024.248689294.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 19 Apr 2017 13:32:48 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqR=jHB2Eh0r6bjcExsU_qkdWFyo23coxBt325aHmcSiuw(at)mail(dot)gmail(dot)com>
> On Wed, Apr 19, 2017 at 12:36 PM, David Rowley
> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> > In favour of "location" -> "lsn": Tom, Stephen, David Steel
> > In favour of "lsn" -> "location": Peter, Kyotaro
>
> I vote for "location" -> "lsn". I would expect complains about the
> current inconsistency at some point, and the function names have been
> already changed for this release..
I won't stick on "location" except that "pg_wal_lsn_diff" seems
no longer useful.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-04-19 08:33:29 | Re: some review comments on logical rep code |
| Previous Message | Kyotaro HORIGUCHI | 2017-04-19 08:25:34 | Re: some review comments on logical rep code |