| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | coelho(at)cri(dot)ensmp(dot)fr |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, rafia(dot)sabih(at)enterprisedb(dot)com, michael(dot)paquier(at)gmail(dot)com, Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, robertmhaas(at)gmail(dot)com, pavel(dot)stehule(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgbench - allow to store select results into variables |
| Date: | 2017-04-17 09:11:23 |
| Message-ID: | 20170417.181123.1539611157606514675.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien,
> Hello Tatsuo-san,
>
>> Thank you for the patch. I tested a little bit and found that it does
>> not allow value replacement against non ascii variables in given SQL
>> statements . Is it intentional?
>
> No, this is a bug.
>
>> If not, I think you need to fix parseVariable() as well.
>
> Indeed. Here is v2.
I think you'd better to change the following comments because there's
no psqlscan.l or psqlscanslash.l in pgbench source tree.
+ * underscore. Keep this in sync with the definition of variable_char in
+ * psqlscan.l and psqlscanslash.l.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-04-17 09:14:01 | Re: Variable substitution in psql backtick expansion |
| Previous Message | Yugo Nagata | 2017-04-17 09:09:21 | CREATE TRIGGER document typo |