Re: pgbench - allow to store select results into variables

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: fabien(dot)coelho(at)mines-paristech(dot)fr
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, rafia(dot)sabih(at)enterprisedb(dot)com, michael(dot)paquier(at)gmail(dot)com, Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, robertmhaas(at)gmail(dot)com, pavel(dot)stehule(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench - allow to store select results into variables
Date: 2017-04-09 23:32:19
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


>> As the variable infrastructures are pretty different between psql &
>> pgbench (typed vs untyped values, sorted array vs linked list data
>> structure, no hook vs 2 hooks, name spaces vs no such thing...), I
>> have chosen the simplest option of just copying the name checking
>> function and extending the lexer to authorize non-ascii letters, so
>> that psql/pgbench would accept the same variable names with the same
>> constraint about encodings.
>> See patch attached & test script.
> Argh, I'm jet-lagged, wrong patch suffix... Here it is with the right
> suffix.

Thank you for the patch. I tested a little bit and found that it does
not allow value replacement against non ascii variables in given SQL
statements . Is it intentional? If not, I think you need to fix
parseVariable() as well.

Best regards,
Tatsuo Ishii
SRA OSS, Inc. Japan

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2017-04-09 23:39:55 Re: partitioned tables and contrib/sepgsql
Previous Message Tom Lane 2017-04-09 23:20:27 Re: "left shift of negative value" warnings