Duplicate assignment in Unicode/convutils.pm

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Duplicate assignment in Unicode/convutils.pm
Date: 2017-04-07 06:32:28
Message-ID: 20170407.153228.167545180.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, I found that convutils.pl contains a harmless duplicate
assignemnt.

> my $out = {f => $fname, l => $.,
> code => hex($1),
> ucs => hex($2),
> comment => $4,
> direction => BOTH,
> f => $fname,
> l => $.
> };

Of course this is utterly harmless but wrong.

The attached patch fixes this following other perl files around.
No similar mistake is not found there.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
convutils_remove_duplicate_assignments.patch text/x-patch 599 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Beena Emerson 2017-04-07 06:59:53 Re: increasing the default WAL segment size
Previous Message Amit Khandekar 2017-04-07 06:14:39 Re: Parallel Append implementation