Re: Logical Replication and Character encoding

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: peter(dot)eisentraut(at)2ndquadrant(dot)com
Cc: petr(dot)jelinek(at)2ndquadrant(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, craig(at)2ndquadrant(dot)com
Subject: Re: Logical Replication and Character encoding
Date: 2017-04-07 01:05:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

At Thu, 6 Apr 2017 14:43:56 -0400, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <330a093a-d155-c866-cbf2-8f36fdf51e95(at)2ndquadrant(dot)com>
> On 4/6/17 11:47, Peter Eisentraut wrote:
> > On 4/5/17 21:32, Kyotaro HORIGUCHI wrote:
> >> At Wed, 5 Apr 2017 11:33:51 -0400, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <5401fef6-c0c0-7e8a-d8b1-169e30cbd854(at)2ndquadrant(dot)com>
> >>> After further thinking, I prefer the alternative approach of using
> >>> pq_sendcountedtext() as is and sticking the trailing zero byte on on the
> >>> receiving side. This is a more localized change, and keeps the logical
> >>> replication protocol consistent with the main FE/BE protocol. (Also, we
> >>> don't need to send a useless byte around.)
> >>
> >> I'm not sure about the significance of the trailing zero in the
> >> the logical replication protocol.
> >
> > It doesn't matter. It could be "nice" to have it because then the
> > receiving side doesn't need to add it if it wants to assemble a C
> > string. But for the reasons above, it doesn't seem worth doing that.

Ok, it's fine for me.

> committed



Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-04-07 01:12:58 Re: Bug with pg_basebackup and 'shared' tablespace
Previous Message Kyotaro HORIGUCHI 2017-04-07 01:02:36 Re: Duplicate usage of tablespace location?