Re: [PATCH] few fts functions for jsonb

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: obartunov(at)gmail(dot)com, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] few fts functions for jsonb
Date: 2017-04-03 18:22:33
Message-ID: 20170403182233.pesqcff4qa56wmj3@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-04-01 16:20:46 -0400, Andrew Dunstan wrote:
>
>
> On 03/31/2017 03:17 PM, Oleg Bartunov wrote:
> >
> >
> > On 30 Mar 2017 23:43, "Dmitry Dolgov" <9erthalion6(at)gmail(dot)com
> > <mailto:9erthalion6(at)gmail(dot)com>> wrote:
> >
> > On 31 March 2017 at 00:01, Andrew Dunstan
> > <andrew(dot)dunstan(at)2ndquadrant(dot)com
> > <mailto:andrew(dot)dunstan(at)2ndquadrant(dot)com>> wrote:
> > >
> > > I have just noticed as I was writing/testing the non-existent
> > docs for
> > > this patch that it doesn't supply variants of to_tsvector that
> > take a
> > > regconfig as the first argument. Is there a reason for that? Why
> > > should the json(b) versions be different from the text versions?
> >
> > No, there is no reason, I just missed that. Here is a new version
> > of the patch (only the functions part)
> > to add those variants.
> >
> >
> > Congratulations with patch committed, who will write an addition
> > documentation? I think we need to touch FTS and JSON parts.

> I added documentation when I committed it for the new functions, in the
> FTS section. I'm not sure what we need to add to the JSON section if
> anything.

I see that the CF entry for this hasn't been marked as committed:
https://commitfest.postgresql.org/13/1054/
Is there anything left here?

- Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-03 18:25:49 Re: Statement timeout behavior in extended queries
Previous Message Andres Freund 2017-04-03 18:21:28 Re: postgres_fdw: evaluate placeholdervars on remote server