Skip site navigation (1) Skip section navigation (2)

Re: Partitioned tables and relfilenode

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp
Cc: amitlangote09(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, m(dot)milyutin(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Partitioned tables and relfilenode
Date: 2017-03-31 08:33:26
Message-ID: 20170331.173326.212311140.horiguchi.kyotaro@lab.ntt.co.jp (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
At Fri, 31 Mar 2017 16:17:05 +0900, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote in <2dec1acb-6e2f-5aa5-0e26-fcc172ce9359(at)lab(dot)ntt(dot)co(dot)jp>
> Horiguchi-san,
> 
> On 2017/03/31 15:50, Kyotaro HORIGUCHI wrote:
> > At Thu, 30 Mar 2017 20:58:35 +0900, Amit Langote wrote:
> >> Updated patch attached.
> > 
> > Thank you.
> > 
> > - Applies cleanly on master (f90d23d)
> > - Compiled without error
> > - Code seems fine.
> > - Documentaion seems fine.. for me.
> > - Passes regression test.
> > - Leaving the ALTER-on-toast.* problem is fine for me.
> 
> Thanks for the review.
> 
> > The regression contains the tests to fail with several reloptions
> > only for partitioned tables. Are they still required even though
> > it is now in the same framework with other kind of reloptions?
> 
> Hmm, maybe we don't really need those tests, so removed.

I have no more comment on this. Thank you.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



In response to

Responses

pgsql-hackers by date

Next:From: Amit LangoteDate: 2017-03-31 08:34:05
Subject: Re: UPDATE of partition key
Previous:From: Kyotaro HORIGUCHIDate: 2017-03-31 08:18:21
Subject: Re: multivariate statistics (v25)

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group