| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: dsm.c API tweak |
| Date: | 2017-03-28 22:48:05 |
| Message-ID: | 20170328224805.yfto4pbbvbt46ab5@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro wrote:
> + if (CurrentResourceOwner)
> + {
> + seg->resowner = CurrentResourceOwner;
> + ResourceOwnerRememberDSM(CurrentResourceOwner, seg);
> + }
>
> You need to assign seg->resowner = CurrentResourceOwner
> unconditionally here. Otherwise seg->resowner is uninitialised junk.
Thanks for that. Pushed, with the comments as I suggested in my other
reply. If you think they merit more wordsmithing, feel free to suggest
something.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-03-28 23:29:48 | Re: logical replication launcher crash on buildfarm |
| Previous Message | Alvaro Herrera | 2017-03-28 22:12:03 | Re: Patch: Write Amplification Reduction Method (WARM) |