Re: Valgrind failures caused by multivariate stats patch

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tv(at)fuzzy(dot)cz>
Subject: Re: Valgrind failures caused by multivariate stats patch
Date: 2017-03-28 15:11:14
Message-ID: 20170328151114.efx45wig76m3lbei@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tomas Vondra wrote:

> OK, this did the trick. And just as I suspected, it seems to be due to doing
> memcpy+offsetof when serializing the statistic into a bytea. The attached
> patch fixes that for me. Can you test it on your build?

Buildfarm member skink confirms that this is fixed. Thanks!

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-03-28 15:16:27 Re: dblink module printing unnamed connection (with commit acaf7ccb94)
Previous Message Andres Freund 2017-03-28 15:08:23 Re: logical decoding of two-phase transactions