Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage
Date: 2017-03-20 12:33:02
Message-ID: 20170320123302.GF9812@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert,

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> So was this 3340 line patch posted or discussed anyplace before it got
> committed?

I've mentioned a few times that I'm working on improving pg_dump
regression tests and code coverage, which is what these were. I'm a bit
surprised that it's, apparently, a surprise to anyone or that strictly
adding regression tests in the existing framework deserves very much
discussion.

What I think would be great would be some additional work on our code
coverage, which is abysmal. This, at least, gets us up over 80% for
src/bin/pg_dump, but there's still quite a bit of work to be done there,
as noted in the commit message, and lots of opportunity for improvement
throughout the rest of the code base, as https://coverage.postgresql.org
shows.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-20 13:07:06 Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage
Previous Message Robert Haas 2017-03-20 11:48:09 Re: pgsql: Improve pg_dump regression tests and code coverage

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-03-20 12:55:09 Re: logical decoding of two-phase transactions
Previous Message Peter Eisentraut 2017-03-20 12:32:54 Re: logical replication access control patches