| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove objname/objargs split for referring to objects |
| Date: | 2017-03-16 15:56:24 |
| Message-ID: | 20170316155624.cjaweygkplodj66i@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier wrote:
> What are you using as CFLAGS? As both typenames should be normally
> set, what about initializing those fields with NULL and add an
> assertion like the attached?
Actually, my compiler was right -- this was an ancient bug I introduced
in 9.5 (commit a61fd533), and this new warning was my compiler being a
bit smarter now for some reason. The problem is we were trying to
extract String value from a TypeName node, which obviously doesn't work
very well.
I pushed a real fix, not just a compiler-silencer, along with a few
lines in object_address.sql to make sure it works properly. Maybe we
need a few more tests cases for other parts of pg_get_object_address.
Pushed fix, backpatched to 9.5.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-16 17:35:07 | pgsql: postgres_fdw: Push down FULL JOINs with restriction clauses. |
| Previous Message | Alvaro Herrera | 2017-03-16 15:51:50 | pgsql: Fix ancient get_object_address_opf_member bug |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2017-03-16 15:56:27 | Re: [PATCH] guc-ify the formerly hard-coded MAX_SEND_SIZE to max_wal_send |
| Previous Message | Robert Haas | 2017-03-16 15:55:56 | Re: [PATCH] guc-ify the formerly hard-coded MAX_SEND_SIZE to max_wal_send |