Re: [PATCH] Suppress Clang 3.9 warnings

From: Noah Misch <noah(at)leadboat(dot)com>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Suppress Clang 3.9 warnings
Date: 2017-03-16 06:55:20
Message-ID: 20170316065520.GA1976012@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This mailing list does not welcome top-post replies.

On Wed, Mar 15, 2017 at 12:04:11PM +0300, Aleksander Alekseev wrote:
> > This is wrong on platforms that do have strlcpy() in libc.
>
> If it no too much trouble could you please explain what will happen
> on such platforms?

Both port.h and a system header will furnish a strlcpy() declaration. The #if
you modified exists to avoid that, and your change would make it ineffective
for Clang. This will have no symptoms, or it will elicit a warning.

> On what platform did you check it?

None.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2017-03-16 07:32:54 Re: Microvacuum support for Hash Index
Previous Message Pavel Stehule 2017-03-16 06:31:45 Re: new set of psql patches for loading (saving) data from (to) text, binary files