| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Leftover invalidation handling in RemoveRelations |
| Date: | 2017-03-15 18:51:26 |
| Message-ID: | 20170315185126.lvfo3td3df6bmhes@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-03-15 14:46:22 -0400, Robert Haas wrote:
> On Wed, Mar 15, 2017 at 2:40 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Yeah, I don't think that would hurt anything.
>
> (I'm not sure it'll help anything either - the overhead of an extra
> AcceptInvalidationMessages() call is quite minimal - but, as you say,
> maybe it's worth doing just to discourage future code authors from
> including unnecessary fluff.)
I don't think there's an actual runtime advantage either - but it's
indeed confusing for others, because it doesn't square with what's
needed. It's not like the AcceptInvalidationMessages() would actually
make things race-free if used without RangeVarGetRelidExtended()...
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-15 19:00:04 | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Previous Message | Robert Haas | 2017-03-15 18:46:22 | Re: Leftover invalidation handling in RemoveRelations |