Re: [COMMITTERS] pgsql: Improve isolation tests infrastructure.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [COMMITTERS] pgsql: Improve isolation tests infrastructure.
Date: 2017-03-15 17:40:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Hi Peter, All,

On 2017-03-14 23:10:19 +0000, Andres Freund wrote:
> Improve isolation tests infrastructure.


I suspect that's because previously src/test/regress/GNUMakefile's
installcheck provided --bindir='$(bindir)', but
$pg_isolation_regress_installcheck) doesn't (and didn't before the

ISTM that the only reason that this previously didn't cause issues on
these machines is that neither actually *runs* any of the isolation
checks in other directories. I.e. they'd have failed before this, too,
if they ran tests using pg_isolation_regress_installcheck.

To me it seems like an oversight in the previous definition of
pg_isolation_regress_installcheck. Looks like that was introduced in;a=commit;h=dcae5faccab64776376d354decda0017c648bb53

Peter, I guess it wasn't intentional that you added --bindir to
pg_regress_installcheck but not pg_isolation_regress_installcheck?



In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-03-15 17:52:36 pgsql: Add more documentation and tests for publications
Previous Message Tom Lane 2017-03-15 17:26:31 pgsql: Rewrite async-connection loop in libpqwalreceiver.c, once again.

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Yanovski 2017-03-15 17:44:09 Re: Defaulting psql to ON_ERROR_ROLLBACK=interactive
Previous Message Tom Lane 2017-03-15 17:33:24 Re: Need a builtin way to run all tests faster manner