| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP: Faster Expression Processing v4 |
| Date: | 2017-03-14 23:40:16 |
| Message-ID: | 20170314234016.5jgz4tjim2xf6j3c@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-03-14 19:34:12 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > [ new patch versions ]
>
> About to leave, but I had time to read 0003:
>
> It seems bizarre that you chose to spell the new configure symbol as
> HAVE__COMPUTED_GOTO rather than HAVE_COMPUTED_GOTO
I went back-and-forth about this a number of times. We have a bunch of
symbols defined with HAVE__ as a prefix (and some with HAVE_GCC__) - and
more of the nearby code seems to use __ rather than _. I don't really
know why we started doing that, but it's far from new..
Any idea why we introduce __ stuff?
> Also, being a neatnik, I would insert both the definition and the
> call of that macro between PGAC_C_BUILTIN_UNREACHABLE and
> PGAC_C_VA_ARGS, keeping it more or less in alphabetical order.
That works for me.
Thanks,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-14 23:44:34 | Re: background sessions |
| Previous Message | Tom Lane | 2017-03-14 23:34:12 | Re: WIP: Faster Expression Processing v4 |