Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> Tom Lane wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > > So now on every startup I get this:
> >
> > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1"
> > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address "127.0.0.1"
> > > 2017-03-13 10:08:49.400 EDT [90059] LOG: listening on Unix address
> > > "/tmp/.s.PGSQL.5432"
> >
> > > I think the idea that this is worth three lines of log output (out of
> > > a total of six) is hard to stomach.
> >
> > You were in the minority before on the usefulness of this output, and
> > I think you still are. Personally I've already found it useful to be
> > able to check that buildfarm runs are binding to (only) the addresses
> > they're supposed to.
>
> I think it's good to have it, but I would argue that it should be a
> single line that lists all the addresses instead.

So, I'm fine with it as-is. Tom's point that it'd get to be a pretty
long line is correct, imv, and other daemons that I've seen also tend to
put them on independent lines and I don't hear many people complaining
about those.

This is NTP's output, for example:

Mar 12 10:13:41 beorn ntpd[28719]: Listen and drop on 0 v6wildcard [::]:123
Mar 12 10:13:41 beorn ntpd[28719]: Listen and drop on 1 v4wildcard 0.0.0.0:123
Mar 12 10:13:41 beorn ntpd[28719]: Listen normally on 2 lo 127.0.0.1:123
Mar 12 10:13:41 beorn ntpd[28719]: Listen normally on 3 wlan0 192.168.1.191:123
Mar 12 10:13:41 beorn ntpd[28719]: Listen normally on 4 lo [::1]:123
Mar 12 10:13:41 beorn ntpd[28719]: Listen normally on 5 wlan0 [fe80::bc2a:e1cf:2545:d08e%3]:123
Mar 12 10:13:41 beorn ntpd[28719]: Listening on routing socket on fd #22 for interface updates

And bind9 (aka named):

Mar 10 10:53:05 tangmo named[7618]: listening on IPv6 interfaces, port 53
Mar 10 10:53:05 tangmo named[7618]: listening on IPv4 interface lo, 127.0.0.1#53
Mar 10 10:53:05 tangmo named[7618]: listening on IPv4 interface eth0, 10.10.5.10#53
Mar 10 10:53:05 tangmo named[7618]: listening on IPv4 interface eth0:ext, 172.16.231.123#53

PowerDNS (aka pdns):

Mar 12 17:15:57 dunmer pdns[26094]: UDP server bound to 0.0.0.0:53
Mar 12 17:15:57 dunmer pdns[26094]: UDPv6 server bound to [::]:53
Mar 12 17:15:57 dunmer pdns[26094]: TCP server bound to 0.0.0.0:53
Mar 12 17:15:57 dunmer pdns[26094]: TCPv6 server bound to [::]:53

Thanks!

Stephen