Re: Declarative partitioning optimization for large amount of partitions

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Tels <nospam-abuse(at)bloodgate(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Declarative partitioning optimization for large amount of partitions
Date: 2017-03-10 12:16:58
Message-ID: 20170310121657.GA25829@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi Tels,

Thanks a lot for the review!

> "corresponding"

Fixed.

> Also a question: Some one-line comments are
>
> /* Comment. */
>
> while others are
>
> /*
> * Comment.
> */
>
> Why the difference?

I'm trying to follow a code stile used in a code I'm modifying. In this
case I got an impression that second style of one-line comments is used
more often an I tried to follow it but apparently I didn't succeed :)
This is fixed as well.

On Thu, Mar 09, 2017 at 06:40:39PM -0500, Tels wrote:
> Hi Aleksander,
>
> noticed this in your patch:
>
> > * Add a corespinding entry to pgStatTabHash.
>
> "corresponding"
>
> Also a question: Some one-line comments are
>
> /* Comment. */
>
> while others are
>
> /*
> * Comment.
> */
>
> Why the difference?
>
> Hope this helps,
>
> Tels

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
partitioning_bottleneck_fix_v3.patch text/x-diff 4.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-03-10 12:49:34 Re: New CORRESPONDING clause design
Previous Message Amit Kapila 2017-03-10 12:08:49 Re: Write Ahead Logging for Hash Indexes