| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Subject: | Re: amcheck (B-Tree integrity checking tool) |
| Date: | 2017-03-10 03:10:28 |
| Message-ID: | 20170310031028.s3y7kftajyty7jmd@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-03-09 19:04:46 -0800, Peter Geoghegan wrote:
> On Thu, Mar 9, 2017 at 4:41 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I don't really expect buildfarm fallout, but ..
>
> Unfortunately, there is some on Windows:
Thanks for monitoring.
> verify_nbtree.obj : error LNK2001: unresolved external symbol
> RecentGlobalXmin
> [C:\buildfarm\buildenv\HEAD\pgsql.build\amcheck.vcxproj]
>
> Rather than marking RecentGlobalXmin as PGDLLIMPORT, I'd rather just
> remove the documenting assertion and leave that comment as-is. I'll
> work on a patch for this soon.
Hm - I think it's fair to export RecentGlobalXmin, given that we
obviously use it across modules in core code. I see very little reason
not to export it.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-03-10 03:12:28 | Re: amcheck (B-Tree integrity checking tool) |
| Previous Message | Peter Geoghegan | 2017-03-10 03:04:46 | Re: amcheck (B-Tree integrity checking tool) |