Re: Adding support for Default partition in partitioning

From: David Fetter <david(at)fetter(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Keith Fiske <keith(at)omniti(dot)com>
Subject: Re: Adding support for Default partition in partitioning
Date: 2017-03-07 16:21:30
Message-ID: 20170307162130.GD24987@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 03, 2017 at 08:10:52AM +0530, Robert Haas wrote:
> On Wed, Mar 1, 2017 at 6:29 AM, Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
> > 3. Handling adding a new partition to a partitioned table
> > with default partition.
> > This will require moving tuples from existing default partition to
> > newly created partition if they satisfy its partition bound.
>
> Considering that this patch was submitted at the last minute and isn't
> even complete, I can't see this getting into v10. But that doesn't
> mean we can't talk about it. I'm curious to hear other opinions on
> whether we should have this feature. On the point mentioned above, I
> don't think adding a partition should move tuples, necessarily; seems
> like it would be good enough - maybe better - for it to fail if there
> are any that would need to be moved.

I see this as a bug fix.

The current state of declarative partitions is such that you need way
too much foresight in order to use them. Missed adding a partition?
Writes fail and can't be made to succeed. This is not a failure mode
we should be forcing on people, especially as it's a massive
regression from the extant inheritance-based partitioning.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2017-03-07 16:27:36 Re: Parallel bitmap heap scan
Previous Message Robert Haas 2017-03-07 16:20:21 Re: Partitioned tables and relfilenode