Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Lukas Fittl <lukas(at)fittl(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements
Date: 2017-03-04 18:46:05
Message-ID: 20170304184605.kbspuoqmr4pnyrvs@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-03-04 11:02:14 -0500, Tom Lane wrote:
> But speaking of ambiguity: isn't it possible for $n symbols to appear in
> pg_stat_statements already?

Indeed.

> I think it is, both from extended-protocol
> client queries and from SPI commands, which would mean that the proposal
> as it stands is not fixing the ambiguity problem at all. So yes, we need
> another idea.

I think using $ to signal a parameter is still a good idea, as people
kinda have to know that one anyway. Maybe one of "$:n" "$-n"?

- Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-03-04 18:52:44 Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements
Previous Message Tomas Vondra 2017-03-04 17:39:28 Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)