| From: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-03-04 15:05:17 |
| Message-ID: | 20170304090517.7e4cc42e@slate.meme.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 4 Mar 2017 14:26:54 +0530
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Mar 3, 2017 at 7:21 PM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
> > But if the code does not exit the loop then
> > before calling elog(ERROR), shouldn't it
> > also call FreeFile(fd)?
>
> Hmm. Normally error recovery cleans up opened files, but since
> logfile_open() directly calls fopen(), that's not going to work here.
> So that does seem to be a problem.
Should something different be done to open the file or is it
enough to call FreeFile(fd) to clean up properly?
Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-04 15:32:59 | Re: Patch to implement pg_current_logfile() function |
| Previous Message | Amit Kapila | 2017-03-04 14:23:23 | Re: wait events for disk I/O |