Re: Skip all-visible pages during second HeapScan of CIC

From: Andres Freund <andres(at)anarazel(dot)de>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skip all-visible pages during second HeapScan of CIC
Date: 2017-03-03 22:54:36
Message-ID: 20170303225435.erbmcn6yn5b3itri@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-02-28 19:12:03 +0530, Pavan Deolasee wrote:
> Since VM bits are only set during VACUUM which conflicts with CIC on the
> relation lock, I don't see any risk of incorrectly skipping pages that the
> second scan should have scanned.

I think that's true currently, but it'd also prevent us from doing that
in additional places. Which, in my opinion, we really should (and I
believe that's realistically achievable). Thus I really don't want to
base the correctness of CIC - a relatively infrequent operation - on the
assumption that no VM bits can be set concurrenty due to the SUE lock.

Regards,

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-03-03 23:03:37 Re: Skip all-visible pages during second HeapScan of CIC
Previous Message Peter Geoghegan 2017-03-03 22:41:33 Re: GUC for cleanup indexes threshold.