Re: objsubid vs subobjid

Peter Eisentraut wrote:
> On 2/22/17 19:35, Jim Nasby wrote:
> > pg_get_object_address() currently returns a field called subobjid, while
> > pg_depend calls that objsubid. I'm guessing that wasn't on purpose
> > (especially because internally the function uses objsubid), and it'd be
> > nice to fix it.
>
> I'm in favor of changing it, but it could theoretically break someone's
> code.

Yes, it was an oversight. +1 for changing.

> I don't know what the practical use for these functions is.

This was originally written for BDR use in DDL replication. Partly the
interfaces exist for testing purposes (to make sure that object
addresses can roundtrip between internal OID numerical representation
and set of names); what BDR uses is the path that goes via event
triggers (pg_event_trigger_ddl_commands and pg_event_trigger_dropped_objects).
I didn't find any use of the name "subobjid" anywhere in BDR.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services