Re: Documentation improvements for partitioning

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Documentation improvements for partitioning
Date: 2017-02-20 20:33:20
Message-ID: 20170220203320.GB2672@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 20, 2017 at 02:37:44PM +0530, Robert Haas wrote:
> On Mon, Feb 20, 2017 at 2:09 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > On 15 February 2017 at 15:46, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >>> It leaves me asking what else is missing.
> >>
> >> There is certainly a lot of room for improvement here but I don't
> >> understand your persistent negativity about what's been done thus far.
> >> I think it's pretty clearly a huge step forward, and I think Amit
> >> deserves a ton of credit for making it happen. The improvements in
> >> bulk loading performance alone are stupendous. You apparently have
> >> the idea that somebody could have written an even larger patch that
> >> solved even more problems at once, but this was already a really big
> >> patch, and IMHO quite a good one.
> >
> > Please explain these personal comments against me.
>
> Several of your emails, including your first post to this thread,
> seemed to me to be quite negative about the state of this feature. I
> don't think that's warranted, though perhaps I am misreading your
> tone, as I have been known to do. I also don't think that expressing
> the opinion that the feature is better than you're giving it credit
> for is a personal comment against you. Where exactly do you see a
> personal comment against you in what I wrote?

I have to admit my reaction was similar to Simon's, meaning that the
lack of docs is a problem, and that the limitations are kind of a
surprise, and I wonder what other surprises there are.

I am thinking this is a result of small teams, often from the same
company, working on a features in isolation and then making them public.
It is often not clear what decisions were made and why. The idea that
unique indexes on a parent table can't guarantee uniqueness across child
tables is both a surprise, and obvious once stated.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message nuko yokohama 2017-02-20 22:11:55 SUBSCRIPTION command hangs up, segfault occurs in the server process and to cancel the execution.
Previous Message Bruce Momjian 2017-02-20 20:27:09 Re: Documentation improvements for partitioning