| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)berkus(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, David Steele <david(at)pgmasters(dot)net>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
| Date: | 2017-02-10 01:02:54 |
| Message-ID: | 20170210010254.GY9812@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Andres Freund (andres(at)anarazel(dot)de) wrote:
> On 2017-02-09 19:19:21 -0500, Stephen Frost wrote:
> > I'd love to nuke pg_shadow and all the other
> > not-really-maintained backwards-compat things from when roles were
> > added too.
>
> Not sure if it's worth the work to rip out and such, but I'm mildly
> supportive of this one too. Depends a bit on what all the other things
> are ;)
Reviewing 7762619e95272974f90a38d8d85aafbe0e94add5 where roles were
added, I find:
pg_user - use pg_roles instead, which actually includes all of the role
attributes, unlike pg_user
pg_shadow - use pg_authid instead, which, again, actually includes all
of the role attributes, unlike pg_shadow.
pg_group - use pg_auth_members instead, which includes the info about
the admin option and the grantor
I don't think we should remove things like CREATE USER, that's a
perfectly reasonable and maintained interface, unlike the above views,
which missed out on things like the 'createrole' role attribute.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2017-02-10 01:03:51 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
| Previous Message | Jim Nasby | 2017-02-10 00:50:02 | Re: Improve OR conditions on joined columns (common star schema problem) |