| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Write Amplification Reduction Method (WARM) |
| Date: | 2017-01-31 14:07:56 |
| Message-ID: | 20170131140756.d6sbkhpsa7jublxc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavan Deolasee wrote:
> On Tue, Jan 31, 2017 at 7:21 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> wrote:
> > CatalogUpdateIndexes was just added as a convenience function on top of
> > a very common pattern. If we now have a reason to create a second one
> > because there are now two very common patterns, it seems reasonable to
> > have two functions. I think I would commit the refactoring to create
> > these functions ahead of the larger WARM patch, since I think it'd be
> > bulky and largely mechanical. (I'm going from this description; didn't
> > read your actual code.)
>
> Sounds good. Should I submit that as a separate patch on current master?
Yes, please.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-31 14:59:35 | Re: Refactoring of replication commands using printsimple |
| Previous Message | Pavan Deolasee | 2017-01-31 14:04:36 | Re: Patch: Write Amplification Reduction Method (WARM) |