| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow interrupts on waiting standby |
| Date: | 2017-01-26 19:20:59 |
| Message-ID: | 20170126192059.jage7owz7lr6csah@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-01-26 12:24:44 -0500, Robert Haas wrote:
> On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > Currently a waiting standby doesn't allow interrupts.
> >
> > Patch implements that.
> >
> > Barring objection, patching today with backpatches.
>
> "today" is a little quick, but the patch looks fine. I doubt anyone's
> going to screech too loud about adding a CHECK_FOR_INTERRUPTS() call.
I don't quite get asking for agreement, and then not waiting as
suggested. I'm personally fine with going with a CHECK_FOR_INTERRUPTS
for now, but I think it'd better to replace it with a latch.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2017-01-26 19:23:24 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
| Previous Message | Andres Freund | 2017-01-26 19:20:04 | Re: increasing the default WAL segment size |