| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increasing the default WAL segment size |
| Date: | 2017-01-26 18:34:46 |
| Message-ID: | 20170126183446.eaz3lcukzchsagw5@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-01-26 13:16:13 -0500, Robert Haas wrote:
> > OK, I have done this refactoring effort as attached because I think
> > that's really worth it. And here are the diff numbers:
> > 3 files changed, 113 insertions(+), 162 deletions(-)
> > That's a bit less than what I thought first because of all the
> > singularities of bytea in its output and the way TIMELINE_HISTORY
> > takes advantage of the message level routines. Still for
> > IDENTIFY_SYSTEM, START_REPLICATION and CREATE_REPLICATION_SLOT the
> > gains in readability are here.
>
> Seems OK to me, but I think I'd want to hear a few other opinions
> before committing it.
Just to be absolutely sure: We're talking about Michael's cleanup patch,
not the thread's original topic?
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-01-26 18:38:53 | Re: [PATCH] Generic type subscription |
| Previous Message | Stephen Frost | 2017-01-26 18:26:10 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |