Re: Commit fest 2017-01 will begin soon!

Michael, all,

* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> There is one week left for this commit fest, and now is the time to
> push for things that have a chance to get in. As of now, there is a
> total of 25 patches waiting for some love from a committer.

Many thanks for your work as CFM this month!

> In the category of Clients, there are some as well:
> - pgbench - more operators and functions.

I don't mind working to review these, but my recollection is that
there's actually still question about just what operators, what
functions, and how we want to handle them. In other words, this
particular patch, imv, could really use a 'summary' email, most likely
from the author, regarding the various opinions raised and the different
view-points presented. Otherwise, I'm not sure it's really going to
make much more progress.

> - pgpassfile connection option.
> - pg_dump, pg_dumpall and data durability.

I'm interested in these. I had thought the data durability one had
another committer already interested and involved, but if not, I may get
to it.

> Now for Miscellaneous:
> - Rename pg_switch_xlog to pg_switch_wal, the name is misleading here
> as this is basically renaming all the system functions including the
> term "xlog" prefix to "wal".

I'm a definite +1 on that happening but, for as much as it's marked
'ready for committer', it's entirely without consensus. I'm not sure
how to resolve that- we could ask some committee to investigate it
further and provide a final determination (core? some other set of
folks?), or simply tally the votes cast and decide to go with whatever
the result of that is, or change the options (and then figure out how to
decide between whatever the new options are..).

> For Monitoring & Control:
> - amcheck (B-Tree integrity checking tool). This patch is in such a
> state for a rather long time...

I'm a big +1 on having this included. In my view, this is similar to
the 'enable checksums by default' question, but without nearly *all* of
the downside. There's no performance impact, there's no usability
issue, the only concerns that I see off-hand are serious bugs that
screw things up and the possibility that it throws an error when nothing
is wrong., neither of which look very likely considering it's been used
extensivly by a number of people and quite a bit at Heroku, as I
understand it. At this point, I tend to doubt that we're going to see
such errors without the broader community embracing and using it, which
means. to me at least, that it's ready to go into core/contrib.

> For server features:
> - Forbid use of LF and CR characters in database and role names.

I'll try and take a look at this. In other words, for me, this comes
before the pgpassfile/pg_dump data durability stuff. I have a couple
other things to clear off my plate, but I expect to get those taken care
of and still have time to handle this too.

> As of the current score of the CF, for a total of 155 patches, 52 have
> been committed, 3 rejected and 7 marked as returned with feedback. It
> may look low, but actually it is not that bad by experience looking at
> those numbers.

We've certainly had some really big patches land during this CF. I'm
hopeful that we won't have any "really big" patches landing for the last
CF, or PG10 is going to be difficult to wrestle out the door.

Thanks again, Michael!

Stephen