Re: Declarative partitioning - another take

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: Declarative partitioning - another take
Date: 2017-01-20 06:15:20
Message-ID: 20170120061520.bzufpx2nc3uszsjj@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-01-19 14:18:23 -0500, Robert Haas wrote:
> Committed.

One of the patches around this topic committed recently seems to cause
valgrind failures like
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2017-01-19%2008%3A40%3A02
:
==24969== Conditional jump or move depends on uninitialised value(s)
==24969== at 0x4C38DA: btint4cmp (nbtcompare.c:97)
==24969== by 0x83860C: FunctionCall2Coll (fmgr.c:1318)
==24969== by 0x536643: partition_bounds_equal (partition.c:627)
==24969== by 0x820864: equalPartitionDescs (relcache.c:1203)
==24969== by 0x82423A: RelationClearRelation (relcache.c:2553)
==24969== by 0x8248BA: RelationFlushRelation (relcache.c:2662)
==24969== by 0x824983: RelationCacheInvalidateEntry (relcache.c:2714)
==24969== by 0x81D9D6: LocalExecuteInvalidationMessage (inval.c:568)
==24969== by 0x81CB0D: ProcessInvalidationMessages (inval.c:444)
==24969== by 0x81D3CB: CommandEndInvalidationMessages (inval.c:1056)
==24969== by 0x4F6735: AtCCI_LocalCache (xact.c:1374)
==24969== by 0x4F8249: CommandCounterIncrement (xact.c:957)
==24969== Uninitialised value was created by a heap allocation
==24969== at 0x85AA83: palloc (mcxt.c:914)
==24969== by 0x53648E: RelationBuildPartitionDesc (partition.c:528)
==24969== by 0x823F93: RelationBuildDesc (relcache.c:1348)
==24969== by 0x8241DB: RelationClearRelation (relcache.c:2524)
==24969== by 0x8248BA: RelationFlushRelation (relcache.c:2662)
==24969== by 0x824983: RelationCacheInvalidateEntry (relcache.c:2714)
==24969== by 0x81D9D6: LocalExecuteInvalidationMessage (inval.c:568)
==24969== by 0x81CB0D: ProcessInvalidationMessages (inval.c:444)
==24969== by 0x81D3CB: CommandEndInvalidationMessages (inval.c:1056)
==24969== by 0x4F6735: AtCCI_LocalCache (xact.c:1374)
==24969== by 0x4F8249: CommandCounterIncrement (xact.c:957)
==24969== by 0x82538B: RelationSetNewRelfilenode (relcache.c:3490)
==24969==
==24969== VALGRINDERROR-END

Regards,

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2017-01-20 06:40:44 Re: Too many autovacuum workers spawned during forced auto-vacuum
Previous Message Andrea Urbani 2017-01-20 05:52:59 Re: [ patch ] pg_dump: new --custom-fetch-table and --custom-fetch-value parameters