| From: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-01-19 13:11:31 |
| Message-ID: | 20170119071131.4a11d66a@slate.meme.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 19 Jan 2017 16:59:10 +0900
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Jan 19, 2017 at 7:27 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > I don't think the "abstract names" stuff is an improvement (just
> > look at the quoting mess in ConfigureNamesString). I think we
> > should do without that; at least as part of this patch. If you
> > think there's code that can get better because of the idea, let's
> > see it.
Fair enough.
FWIW, when I first wrote the "abstract names" stuff there were another
half dozen or so occurrences of the constants.
Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jesper Pedersen | 2017-01-19 13:43:56 | Re: Microvacuum support for Hash Index |
| Previous Message | Pavan Deolasee | 2017-01-19 13:05:21 | Re: Patch: Write Amplification Reduction Method (WARM) |