Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin
Date: 2017-01-09 19:33:03
Message-ID: 20170109193303.txhqsclrtuhc2hfo@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kuntal Ghosh wrote:
> Hi all,
>
> In brin_doupdate(line 290), REGBUF_STANDARD is used to register
> revmap buffer reference in WAL record. But, revmap buffer page doesn't
> have a standard page layout and it doesn't update pd_upper and
> pd_lower as well.

Hmm. This bug should be causing WAL replay to zero out the revmap page
contents, since essentially the whole page is covered by the "hole" in
standard pages. I can't see what is causing that not to happen, but
evidently it isn't, since the index works in a replica. What am I
missing?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-01-09 19:34:27 Re: Add support to COMMENT ON CURRENT DATABASE
Previous Message Tom Lane 2017-01-09 19:22:14 Re: Increase pltcl test coverage