Re: pgsql: Fix tab completion in psql for ALTER DEFAULT PRIVILEGES

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix tab completion in psql for ALTER DEFAULT PRIVILEGES
Date: 2016-12-24 04:03:48
Message-ID: 20161224040348.GG18360@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Fri, Dec 23, 2016 at 9:02 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > Lastly, we weren't using the actual list of allowed kinds of
> > objects for default privileges for completion after the 'GRANT X ON' but
> > instead were completeing to what 'GRANT X ON' supports, which isn't the
> > ssame at all.
>
> /me scratches head.

'ALTER DEFAULT PRIVILEGES ... GRANT X ON' can be followed by the literal
term 'TABLES', or 'FUNCTIONS', etc.

'GRANT X ON ' can be followed by an actual table.

A bit awkward to write out in a single sentence though.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2016-12-24 06:44:25 pgsql: pg_dumpall: Include --verbose option in --help output
Previous Message Robert Haas 2016-12-24 03:58:38 Re: pgsql: Fix tab completion in psql for ALTER DEFAULT PRIVILEGES