| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples |
| Date: | 2016-12-06 03:38:03 |
| Message-ID: | 20161206033802.dklbbnrzfnx6ddhc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Permit dump/reload of not-too-large >1GB tuples
>
> I apologize for not having paid close enough attention earlier, but:
> this patch is absolutely unacceptable for the back branches and MUST
> be reverted there. Adding another field to StringInfoData is an ABI
> change that will certainly break large numbers of extensions. We
> can't expect those to get recompiled for minor releases.
Oh, I see the problem now -- it can (and frequently is) stack allocated,
not just palloc'ed using the StringInfo api, and changing the size
breaks that. Rats. I'll revert tomorrow.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2016-12-06 08:09:52 | pgsql: Improve documentation about pg_stat_replication view. |
| Previous Message | Tom Lane | 2016-12-06 03:10:46 | Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-12-06 03:49:55 | WIP: Faster Expression Processing and Tuple Deforming (including JIT) |
| Previous Message | Tom Lane | 2016-12-06 03:10:46 | Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples |