| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pavel(dot)stehule(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IF (NOT) EXISTS in psql-completion |
| Date: | 2016-11-28 10:13:50 |
| Message-ID: | 20161128.191350.96001503.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for reviewing but I ran out of time for this CF..
I'm going to move this to the next CF.
At Fri, 25 Nov 2016 15:14:27 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20161125(dot)151427(dot)53669441(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> Hello,
>
> At Fri, 25 Nov 2016 06:51:43 +0100, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote in <CAFj8pRAm2CsafiH0CPxoWyTccJSm+y=TVgzq07gGS5ydS0qwCA(at)mail(dot)gmail(dot)com>
> > I am sure about benefit of all patches - but it is lot of changes in one
> > moment, and it is not necessary in this moment.
> >
> > patches 0004 and 0005 does some bigger mental changes, and the work can be
> > separated.
>
> The patches are collestions of sporadic changes on the same
> basis. I agree that the result is too big too look at. (And the
> code itself is confused) Please wait for a while for separated
> patches.
I'm working on it but ran out of time. I'm going to be unplugged
until next Monday. So I move this to the next CF.
The attached pathes are an incomplete work of the
separation. Still contains some confusions among patches but far
easier to look at, I think.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactoring-tab-complete-to-make-psql_completion-cod.patch | text/x-patch | 125.5 KB |
| 0002-Make-keywords-case-follow-to-input.patch | text/x-patch | 43.0 KB |
| 0003-Introduce-word-shift-and-removal-feature-to-psql-com.patch | text/x-patch | 15.6 KB |
| 0004-Allow-complete-schema-elements-in-more-natural-way.patch | text/x-patch | 12.7 KB |
| 0005-Simpilfy-ALTER-TABLE-ALTER-COLUMN-completion.patch | text/x-patch | 2.6 KB |
| 0006-Simplify-completion-for-CLUSTER-VERBOSE.patch | text/x-patch | 1.6 KB |
| 0007-Simplify-completion-for-COPY.patch | text/x-patch | 2.6 KB |
| 0008-Simplify-completion-for-CREATE-INDEX.patch | text/x-patch | 4.4 KB |
| 0009-Simplify-completion-for-CREATE-SEQUENCE.patch | text/x-patch | 1.4 KB |
| 0010-Simplify-completion-for-DROP-INDEX.patch | text/x-patch | 1.2 KB |
| 0011-Allow-completing-the-body-of-EXPLAIN.patch | text/x-patch | 1.2 KB |
| 0012-Allow-CREATE-RULE-to-use-command-completion-recursiv.patch | text/x-patch | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2016-11-28 10:16:33 | A bug of psql completion |
| Previous Message | Artur Zakirov | 2016-11-28 09:39:54 | Re: proposal: session server side variables |