| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvements in psql hooks for variables |
| Date: | 2016-11-21 13:59:18 |
| Message-ID: | 20161121135918.GK13284@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel,
* Daniel Verite (daniel(at)manitou-mail(dot)org) wrote:
> Stephen Frost wrote:
>
> > Are you working to make those changes? I'd rather we make the changes
> > to this code once rather than push what you have now only to turn around
> > and change it significantly again.
>
> If, as a maintainer, you prefer this together in one patch, I'm fine
> with that. So I'll update it shortly with changes in \timing and
> a few other callers of ParseVariableBool().
Did you get a chance to review and consider the other comments from my
initial review about how we might use a different approach for bools, et
al?
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Svedov | 2016-11-21 14:32:20 | postgres 9.3 postgres_fdw ::LOG: could not receive data from client: Connection reset by peer |
| Previous Message | Stephen Frost | 2016-11-21 13:58:24 | Re: Improvements in psql hooks for variables |