Re: A bug in UCS_to_most.pl

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: robertmhaas(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: A bug in UCS_to_most.pl
Date: 2016-11-17 12:24:06
Message-ID: 20161117.212406.113820679.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 15 Nov 2016 09:44:54 -0500, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in <CA+Tgmoaqtq8u89PwmxyrRhr8oKy4Hz5S+bTzqZ=0n=XxU9bYiA(at)mail(dot)gmail(dot)com>
> On Tue, Nov 8, 2016 at 3:56 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > I was surprised to find that
> > src/backend/utils/mb/Unicode/Makefile got changed (3a47c70) to
> > have download feature of character conversion authority files. It
> > seems fine according to the previous discussion as the commnet of
> > that is saying.
> >
> > So, I did 'make maintainer-clean; make' on it but got the
> > following error.
> >
> >> Hash %filename missing the % in argument 1 of keys() at UCS_to_most.pl line 51.'/usr/bin/perl' UCS_to_most.pl
> >
> > What is more surprising to find that it is there since
> > 2006. Maybe Heikki unintentionally fixed that in the patch in the
> > thread, or older perls might not have complained about it (my
> > perl is 5.16).
> >
> > Anyway, the attached small patch fixes it.
>
> It's quite amazing to me that that ever worked for anyone. Committed.

Thanks.

As for myself, Probably I have never ran UCS_to_most.pl. Maybe no
one ran it since the patch.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-11-17 15:06:28 Re: Unlogged tables cleanup
Previous Message Dmitry Dolgov 2016-11-17 11:56:11 Re: [PATCH] Generic type subscription