| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Date: | 2016-11-14 20:14:10 |
| Message-ID: | 20161114201410.ctgglamtdu2u5yj3@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2016-11-12 11:42:12 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2016-11-12 11:30:42 -0500, Tom Lane wrote:
> >> which is a rather blatant waste of cycles. I would suggest an explicit
> >> do-nothing installcheck rule rather than the hack you came up with here.
>
> > I had that at first, but that generates a warning about overwriting the
> > makefile target - which afaics cannot be fixed.
>
> Hm. What about inventing an additional macro NO_INSTALLCHECK that
> prevents pgxs.mk from generating an installcheck rule? It's not
> like we don't have similar issues elsewhere, eg contrib/sepgsql.
Well, that one seems a bit different. Seems easy enough to do. Do we
want to make that macro that prevents installcheck from being defined,
or one that forces it to be empty? The former has the disadvantage that
one has to be careful to define a target, to avoid breaking recursion
from the upper levels.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-11-14 20:32:59 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Magnus Hagander | 2016-11-14 16:33:32 | pgsql: Fix typo in comment |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-11-14 20:32:59 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Andrew Dunstan | 2016-11-14 20:12:24 | Re: Do we need use more meaningful variables to replace 0 in catalog head files? |