| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Date: | 2016-11-12 16:35:08 |
| Message-ID: | 20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2016-11-12 11:30:42 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Committed after simplifying the Makefile.
>
> While I have no particular objection to adding these tests, the
> commit log's claim that this will improve buildfarm testing is
> quite wrong. The buildfarm runs "make installcheck" not
> "make check" in contrib.
Gah. It was more aimed at the coverage stuff, but that might work the
same. Alvaro?
> which is a rather blatant waste of cycles. I would suggest an explicit
> do-nothing installcheck rule rather than the hack you came up with here.
I had that at first, but that generates a warning about overwriting the
makefile target - which afaics cannot be fixed.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-12 16:42:12 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Tom Lane | 2016-11-12 16:30:42 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-12 16:42:12 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Tom Lane | 2016-11-12 16:30:42 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |