Re: Patch: Implement failover on libpq connect level.

From: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2016-10-24 19:38:57
Message-ID: 20161024223857.0802f39f@wagner.wagner.home
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackerspgsql-jdbc

On Wed, 19 Oct 2016 12:04:27 -0400
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Oct 13, 2016 at 5:53 AM, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
> wrote:
> > On Thu, 13 Oct 2016 12:30:59 +0530
> > Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> wrote:
> >> On Fri, Sep 30, 2016 at 2:14 PM, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
> >> wrote:
> >> Okay but for me consistency is also important. Since we agree to
> >> disagree on some of the comments and others have not expressed any
> >> problem I am moving it to committer.
> >
> > Thank you for your efforts improving my patch
>
> I haven't deeply reviewed this patch, but on a quick read-through it
> certainly seems to need a lot of cleanup work.
>

I've did some cleanup, i.e. running pgindent, spell-checking comments
and indenting sgml and attaching cleaned up version here.

I've also re-added test file t/001-multihost.pl which get lost from
previous post.

Thanks for your suggestions.

--
Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>

Attachment Content-Type Size
libpq-failover-12.patch text/x-patch 60.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2016-10-24 19:51:32 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Previous Message Pavel Stehule 2016-10-24 19:33:35 Re: PL/Python adding support for multi-dimensional arrays

Browse pgsql-jdbc by date

  From Date Subject
Next Message Peter Eisentraut 2016-10-24 20:10:32 Re: Patch: Implement failover on libpq connect level.
Previous Message Robert Haas 2016-10-24 15:57:27 Re: Patch: Implement failover on libpq connect level.