Re: FSM corruption leading to errors

Tom Lane wrote:

> Ah, scratch that, after rereading the FSM README I see it's correct,
> because there's a binary tree within each page; I'd only remembered
> that there was a search tree of pages.
>
> Also, we could at least discount the FSM root page and first intermediate
> page, no? That is, the upper limit could be
>
> pg_relation_size(oid::regclass, 'fsm') / 2 - 2*current_setting('block_size')::BIGINT
>
> I think this is a worthwhile improvement because it reduces the time spent
> on small relations. For me, the query as given takes 9 seconds to examine
> the regression database, which seems like a lot. Discounting two pages
> reduces that to 20 ms.

Hah, good one. We spent some time thinking about subtracting some value
to make the value more accurate but it didn't occur to me to just use
constant two.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services