Re: Patch: Implement failover on libpq connect level.

From: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2016-10-24 11:03:22
Message-ID: 20161024140322.12069b94@fafnir.local.vm
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On Mon, 24 Oct 2016 11:36:31 +0100
Thom Brown <thom(at)linux(dot)com> wrote:

> > - It's pretty clear that this isn't going to work if the host list
> > includes a mix of hostnames and UNIX socket addresses. The code
> > that handles the UNIX socket address case is totally separate from
> > the code that handles the multiple-hostname case.
>
> So should it be the case that it disallows UNIX socket addresses
> entirely? I can't imagine a list of UNIX socket addresses being that
> useful.

Really, patch was implemented as TCP-only from the beginning.

I know only one case, where list of UNIX sockets is useful - test suite.
I have to include modifications to PostgresNode.pm in the patch to
allow testing with TCP sockets.

Also, I can imagine that people would want include one unix socket into
list of TCP ones, i.e. one of replicas running on the same host as
application server. But patch doesn't support it. May be it should be
clarified in the documentation, that this is not supported.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Victor Wagner 2016-10-24 11:09:57 Re: Patch: Implement failover on libpq connect level.
Previous Message Jeevan Chalke 2016-10-24 10:46:02 Re: Aggregate Push Down - Performing aggregation on foreign server

Browse pgsql-jdbc by date

  From Date Subject
Next Message Victor Wagner 2016-10-24 11:09:57 Re: Patch: Implement failover on libpq connect level.
Previous Message Thom Brown 2016-10-24 10:36:31 Re: Patch: Implement failover on libpq connect level.